feat: [TKC-3016] fix defaultConfigs for TestWorkflow executions #6093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exu
approved these changes
Dec 19, 2024
rangoo94
reviewed
Dec 19, 2024
There was a problem hiding this comment.
Why we should populate the default values in that case? It will make it impossible to determine between [lack of config] vs [ignored config (sensitive or too big value)] vs [empty string].
This means, that both FE and Re-Run won't know if the configParams is empty because defaults have been used, or is empty because sensitive (or too big) data are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
When request.Config is empty we don't provide defaultValues.
This fixes that, but also keeps so when sensitive is provided no values are returned
Checklist (choose whats happened)
Breaking changes
Changes
Fixes