Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: common script source for git ops #890

Merged
merged 35 commits into from
Feb 8, 2022
Merged

feat: common script source for git ops #890

merged 35 commits into from
Feb 8, 2022

Conversation

exu
Copy link
Member

@exu exu commented Jan 28, 2022

Pull request description

Changed data structure for content - Needs new operator, and executors to follow up

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

Copy link
Collaborator

@vsukhin vsukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few questions

pkg/executor/client/common.go Outdated Show resolved Hide resolved
pkg/executor/content/fetcher.go Show resolved Hide resolved
pkg/executor/content/fetcher.go Outdated Show resolved Hide resolved
pkg/executor/content/fetcher.go Show resolved Hide resolved
pkg/mapper/scripts/kube_openapi.go Outdated Show resolved Hide resolved
@vsukhin
Copy link
Collaborator

vsukhin commented Jan 31, 2022

Will also need to update testkube operator with latest changes to Script model

@exu exu changed the title feat: script source feat: common script source for git ops Feb 1, 2022
@exu exu marked this pull request as ready for review February 2, 2022 14:08
@exu exu requested a review from vsukhin February 2, 2022 14:08
@exu exu merged commit 3b38405 into main Feb 8, 2022
@exu exu deleted the feat/scripts-source branch February 8, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants