Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Reflect the Transactions to Test Suites #3051

Merged
merged 5 commits into from
Aug 16, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Aug 9, 2023

This PR updates the documentation to reflect the naming change from Transactions to Test Suites

Changes

  • Updates the file names
  • Updates texts and images
  • Keeps the same overall message as the logic is the same but with a different name

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

https://www.loom.com/share/791c34547af447dcbec4ac8dfaef1501

@xoscar xoscar self-assigned this Aug 9, 2023
@xoscar xoscar requested review from adnanrahic, schoren, jfermi and kdhamric and removed request for schoren August 9, 2023 21:07
@xoscar xoscar added the documentation Improvements or additions to documentation label Aug 9, 2023
@xoscar xoscar marked this pull request as ready for review August 9, 2023 21:13
This page showcases how to create and edit Test Suites with the CLI.

:::tip
[To read more about test suites check out test suites concepts.](../concepts/test-suites.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[To read more about test suites check out test suites concepts.](../concepts/test-suites.md)
[To read more about Test Suites check out the Test Suites concepts page.](../concepts/test-suites.md)

[To read more about test suites check out test suites concepts.](../concepts/test-suites.md)
:::

Just like other structures of Tracetest, you can also manage your test suites using the CLI and definition files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Just like other structures of Tracetest, you can also manage your test suites using the CLI and definition files.
Just like other structures of Tracetest, you can also manage your Test Suites using the CLI and definition files.


Just like other structures of Tracetest, you can also manage your test suites using the CLI and definition files.

A definition file for a test suite looks like the following:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A definition file for a test suite looks like the following:
A definition file for a Test Suite looks like the following:

- testID # you can also reference tests by their ids instead of referencing the definition file
```

In order to apply this test suite to your Tracetest instance, make sure to have your [CLI configured](./configuring-your-cli.md) and run:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In order to apply this test suite to your Tracetest instance, make sure to have your [CLI configured](./configuring-your-cli.md) and run:
In order to apply this Test Suite to your Tracetest instance, make sure to have your [CLI configured](./configuring-your-cli.md) and run:

tracetest apply testsuite -f <testsuite.yaml>
```

> If the file contains the property `spec.id`, the operation will be considered a test suite udpate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> If the file contains the property `spec.id`, the operation will be considered a test suite udpate.
> If the file contains the property `spec.id`, the operation will be considered a Test Suite update.


Once you have created a transaction, whether from the Tracetest UI or via a text editor, you will need the capabity to run it via the Command Line Interface (CLI) to integrate it into your CI/CD process or your local development workflow.
Once you have created a test suite, whether from the Tracetest UI or via a text editor, you will need the capabity to run it via the Command Line Interface (CLI) to integrate it into your CI/CD process or your local development workflow.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once you have created a test suite, whether from the Tracetest UI or via a text editor, you will need the capabity to run it via the Command Line Interface (CLI) to integrate it into your CI/CD process or your local development workflow.
Once you have created a Test Suite, whether from the Tracetest UI or via a text editor, you will need the capability to run it via the Command Line Interface (CLI) to integrate it into your CI/CD process or your local development workflow.


The command to run a transaction is the same as running a test from the CLI.
The command to run a test suite is the same as running a test from the CLI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The command to run a test suite is the same as running a test from the CLI.
The command to run a Test Suite is the same as running a test from the CLI.


To run a transaction, give the path to the transaction definition file with the `'-f'` option. This will launch a transaction, providing us with a link to the created transaction run.
To run a test suite, give the path to the test suite definition file with the `'-f'` option. This will launch a test suite, providing us with a link to the created test suite run.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To run a test suite, give the path to the test suite definition file with the `'-f'` option. This will launch a test suite, providing us with a link to the created test suite run.
To run a Test Suite, give the path to the Test Suite definition file with the `'-f'` option. This will launch a Test Suite, providing us with a link to the created Test Suite run.


There are two ways of referencing a variable set when running a transaction.
There are two ways of referencing a variable set when running a test suite.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are two ways of referencing a variable set when running a test suite.
There are two ways of referencing a variable set when running a Test Suite.


You can reference an existing variable set using its id. For example, given this defined variable set with an id of `'testenv'`:

![testenv](../img/show-environment-definition.png)

We can run a transaction and specify that variable set with this command:
We can run a test suite and specify that variable set with this command:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We can run a test suite and specify that variable set with this command:
We can run a Test Suite and specify that variable set with this command:

@@ -1,6 +1,6 @@
# Undefined Variables

When a user runs a test or a transaction, any variables that will be needed but are not defined will be prompted for:
When a user runs a test or a test suite, any variables that will be needed but are not defined will be prompted for:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When a user runs a test or a test suite, any variables that will be needed but are not defined will be prompted for:
When a user runs a Test or a Test Suite, any variables that will be needed but are not defined will be prompted for:

@@ -13,7 +13,7 @@ POKEID:
POKENAME:
```

Undefined variables are dependent on the variable set selected and whether or not the variable is defined in the current variable set. Select the variable set to run the test or transaction by passing it into the test run command.
Undefined variables are dependent on the variable set selected and whether or not the variable is defined in the current variable set. Select the variable set to run the test or test suite by passing it into the test run command.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Undefined variables are dependent on the variable set selected and whether or not the variable is defined in the current variable set. Select the variable set to run the test or test suite by passing it into the test run command.
Undefined variables are dependent on the variable set selected and whether or not the variable is defined in the current variable set. Select the variable set to run the Test or Test Suite by passing it into the `test run` command.

@@ -14,15 +14,15 @@ This page showcases use-cases for undefined variables and how to enable ad-hoc t

### **Supply Variable Value at Runtime**

A user wants a test or transaction they can run on a particular user, order id, etc. that is configurable at run time. This makes running an adhoc test in an environment, even production, very easy and convenient. In this case, the user references the variable, but doesn't add it to the environment. Each time they run the test or transaction, they will be prompted for the unspecified variables.
A user wants a test or test suite they can run on a particular user, order id, etc. that is configurable at run time. This makes running an adhoc test in an environment, even production, very easy and convenient. In this case, the user references the variable, but doesn't add it to the environment. Each time they run the test or test suite, they will be prompted for the unspecified variables.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A user wants a test or test suite they can run on a particular user, order id, etc. that is configurable at run time. This makes running an adhoc test in an environment, even production, very easy and convenient. In this case, the user references the variable, but doesn't add it to the environment. Each time they run the test or test suite, they will be prompted for the unspecified variables.
A user wants a test or Test Suite they can run on a particular user, order id, etc. that is configurable at run time. This makes running an adhoc test in an environment, even production, very easy and convenient. In this case, the user references the variable, but doesn't add it to the environment. Each time they run the Test or Test Suite, they will be prompted for the unspecified variables.


### **Supply Variable Value from a Previous Test**

A user wants to define 3 tests as part of a transaction. The first test has an output variable and this output is used by the second test. They define the first test. They then define the second test and reference the variable value that is output from the first test.
A user wants to define 3 tests as part of a test suite. The first test has an output variable and this output is used by the second test. They define the first test. They then define the second test and reference the variable value that is output from the first test.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A user wants to define 3 tests as part of a test suite. The first test has an output variable and this output is used by the second test. They define the first test. They then define the second test and reference the variable value that is output from the first test.
A user wants to define 3 tests as part of a Test Suite. The first test has an output variable and this output is used by the second test. They define the first test. They then define the second test and reference the variable value that is output from the first test.

@@ -40,10 +40,10 @@ In Tracetest, undefined variables can be used in both the UI and CLI.

![Test Output](../img/test-output.png)

5. Now, you can create a transaction with the two tests - first, add the list test, then the add test, and then the list test again:
5. Now, you can create a test suite with the two tests - first, add the list test, then the add test, and then the list test again:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
5. Now, you can create a test suite with the two tests - first, add the list test, then the add test, and then the list test again:
5. Now, you can create a Test Suite with the two tests - first, add the list test, then the add test, and then the list test again:

Most End-to-End tests are not simple to run. They require some setup before the actual test is run. Actions like creating a new user, removing all items from a cart, etc. It is important that you can execute multiple steps as part of your test suite. Tracetest introduces the concept of **Test Suites** to achieve this goal.

## What is a Test Suite?
A test suite is defined as a group of steps that are executed in the defined order and can access information exported by previous step executions. Each step is a test.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A test suite is defined as a group of steps that are executed in the defined order and can access information exported by previous step executions. Each step is a test.
A Test Suite is defined as a group of steps that are executed in the defined order and can access information exported by previous step executions. Each step is a test.

A test suite is defined as a group of steps that are executed in the defined order and can access information exported by previous step executions. Each step is a test.

## Chaining Tests
The main benefit of using test suites is to chain tests together and use values obtained from a test in a subsequent test.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The main benefit of using test suites is to chain tests together and use values obtained from a test in a subsequent test.
The main benefit of using Test Suites is to chain tests together and use values obtained from a test in a subsequent test.

The main benefit of using test suites is to chain tests together and use values obtained from a test in a subsequent test.

### How Values are Shared by Tests
When a test suite is run, a context object is created with information about that specific run. One of those pieces of information is a `variable set` object, which is empty by default. If the test suite is run when referencing an [variable set](./variable-sets.md), all values from the selected variable sets will be copied to the `variable set` object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When a test suite is run, a context object is created with information about that specific run. One of those pieces of information is a `variable set` object, which is empty by default. If the test suite is run when referencing an [variable set](./variable-sets.md), all values from the selected variable sets will be copied to the `variable set` object.
When a Test Suite is run, a context object is created with information about that specific run. One of those pieces of information is a `variable set` object, which is empty by default. If the Test Suite is run when referencing an [variable set](./variable-sets.md), all values from the selected variable sets will be copied to the `variable set` object.

### How Values are Shared by Tests
When a test suite is run, a context object is created with information about that specific run. One of those pieces of information is a `variable set` object, which is empty by default. If the test suite is run when referencing an [variable set](./variable-sets.md), all values from the selected variable sets will be copied to the `variable set` object.

When a test is executed within a test suite, if it generates any outputs, its outputs will be injected into the test suite context variable set object. After the outputs are injected, all subsequent tests to be run within the test suite will be able to reference those values.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When a test is executed within a test suite, if it generates any outputs, its outputs will be injected into the test suite context variable set object. After the outputs are injected, all subsequent tests to be run within the test suite will be able to reference those values.
When a test is executed within a Test Suite, if it generates any outputs, its outputs will be injected into the test suite context variable set object. After the outputs are injected, all subsequent tests to be run within the Test Suite will be able to reference those values.


When a test is executed within a test suite, if it generates any outputs, its outputs will be injected into the test suite context variable set object. After the outputs are injected, all subsequent tests to be run within the test suite will be able to reference those values.

> :information_source: Outputs generated by steps don't modify the selected [variable set](./variable-sets.md). It only modifies the test suite run context object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> :information_source: Outputs generated by steps don't modify the selected [variable set](./variable-sets.md). It only modifies the test suite run context object.
> :information_source: Outputs generated by steps don't modify the selected [variable set](./variable-sets.md). It only modifies the Test Suite run context object.


> :information_source: Outputs generated by steps don't modify the selected [variable set](./variable-sets.md). It only modifies the test suite run context object.

Consider you have 3 tests within a test suite: A, B, and C. Tests A and B generate outputs called A_OUTPUT and B_OUTPUT, respectively. When running the test suite, we provide a variable set which contains a `HOST` variable. The execution of test A would only be able to reference `env:HOST`. B would be able to reference `env:HOST`, and `env:A_OUTPUT`. While C would be able to reference all three variables: `env:HOST`, `env:A_OUTPUT`, `env:B_OUTPUT`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Consider you have 3 tests within a test suite: A, B, and C. Tests A and B generate outputs called A_OUTPUT and B_OUTPUT, respectively. When running the test suite, we provide a variable set which contains a `HOST` variable. The execution of test A would only be able to reference `env:HOST`. B would be able to reference `env:HOST`, and `env:A_OUTPUT`. While C would be able to reference all three variables: `env:HOST`, `env:A_OUTPUT`, `env:B_OUTPUT`.
Consider you have 3 tests within a Test Suite: A, B, and C. Tests A and B generate outputs called A_OUTPUT and B_OUTPUT, respectively. When running the Test Suite, we provide a variable set which contains a `HOST` variable. The execution of test A would only be able to reference `env:HOST`. B would be able to reference `env:HOST`, and `env:A_OUTPUT`. While C would be able to reference all three variables: `env:HOST`, `env:A_OUTPUT`, `env:B_OUTPUT`.

expression: attr:tracetest.time.start
```

This would create an output called `TIME_CANCEL_SUBSCRIPTION_MESSAGE_OBTAINED` that is obtained by reading the attribute `tracetest.time.start` from the span with `name` equal to `Process request from cancel subscription queue`. This value would then be injected into the variables of that test suite to be accessed by other tests within the same test suite run.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This would create an output called `TIME_CANCEL_SUBSCRIPTION_MESSAGE_OBTAINED` that is obtained by reading the attribute `tracetest.time.start` from the span with `name` equal to `Process request from cancel subscription queue`. This value would then be injected into the variables of that test suite to be accessed by other tests within the same test suite run.
This would create an output called `TIME_CANCEL_SUBSCRIPTION_MESSAGE_OBTAINED` that is obtained by reading the attribute `tracetest.time.start` from the span with `name` equal to `Process request from cancel subscription queue`. This value would then be injected into the variables of that Test Suite to be accessed by other tests within the same Test Suite run.


### Test Suites Execution Flow

Test Suite steps are executed sequentially. A next step is only executed after the previous step finishes executing successfully. A successful step is one which managed to trigger an operation and received a trace back from the data store. Failing assertions do not stop a test suite from executing the next steps.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Test Suite steps are executed sequentially. A next step is only executed after the previous step finishes executing successfully. A successful step is one which managed to trigger an operation and received a trace back from the data store. Failing assertions do not stop a test suite from executing the next steps.
Test Suite steps are executed sequentially. A next step is only executed after the previous step finishes executing successfully. A successful step is one which managed to trigger an operation and received a trace back from the data store. Failing assertions do not stop a Test Suite from executing the next steps.


We can do that by creating the tests and transactions through the Web UI or using the CLI. In this example, we will use the CLI to create a Variable Set and then create the transaction with all tests needed. The [assertions](../../../concepts/assertions.md) that we will check are the same for every single test.
We can do that by creating the tests and test suites through the Web UI or using the CLI. In this example, we will use the CLI to create a Variable Set and then create the test suite with all tests needed. The [assertions](../../../concepts/assertions.md) that we will check are the same for every single test.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We can do that by creating the tests and test suites through the Web UI or using the CLI. In this example, we will use the CLI to create a Variable Set and then create the test suite with all tests needed. The [assertions](../../../concepts/assertions.md) that we will check are the same for every single test.
We can do that by creating the Tests and Test Suites through the Web UI or using the CLI. In this example, we will use the CLI to create a Variable Set and then create the Test Suite with all tests needed. The [assertions](../../../concepts/assertions.md) that we will check are the same for every single test.

@@ -172,16 +172,16 @@ spec:
- ./checkout.yaml
```

By having the test, transaction and environment files in the same directory, we can call the CLI and execute this transaction:
By having the test, test suite and environment files in the same directory, we can call the CLI and execute this test suite:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By having the test, test suite and environment files in the same directory, we can call the CLI and execute this test suite:
By having the Test, Test Suite and Environment Files in the same directory, we can call the CLI and execute this Test Suite:

This page showcases how to create and edit Test Suites in the Web UI.

:::tip
[To read more about test suites check out test suites concepts.](../concepts/test-suites.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[To read more about test suites check out test suites concepts.](../concepts/test-suites.md)
[To read more about Test Suites check out the Test Suites concepts page.](../concepts/test-suites.md)


![Create a Test Button](../img/create-button-0.11.png)

Give your test suite a name, and click **Next**:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Give your test suite a name, and click **Next**:
Give your Test Suite a name, and click **Next**:


![Name the Test Suite](https://res.cloudinary.com/djwdcmwdz/image/upload/v1685712802/docs/beta.tracetest.io__page_1_jynf6o.png)

Next, select which tests to run in the test suite and click **Create & Run**:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Next, select which tests to run in the test suite and click **Create & Run**:
Next, select which tests to run in the Test Suite and click **Create & Run**:


![Select Tests in Test Suite](https://res.cloudinary.com/djwdcmwdz/image/upload/v1685712954/docs/beta.tracetest.io__page_1_1_agjvg0.png)

The test suite will start:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The test suite will start:
The Test Suite will start:


![Running Test Suite](../img/running-testsuite.png)

On the automate tab, you find methods to automate the current test suite, including the YAML test file and the CLI command for Tracetest.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
On the automate tab, you find methods to automate the current test suite, including the YAML test file and the CLI command for Tracetest.
On the automate tab, you find methods to automate the current Test Suite, including the YAML test file and the CLI command for Tracetest.


With all of the toggles `Off`, each criteria is tested. Toggle individual criteria `On`, to select on certain checks for the selected test.

When the test suite is finished, you will get the following result:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When the test suite is finished, you will get the following result:
When the Test Suite is finished, you will get the following result:


![Finished Test Suite](https://res.cloudinary.com/djwdcmwdz/image/upload/v1685713712/docs/demo.tracetest.io__x0o1gu.png)

You can now view individual [Test Results](test-results.md) executed by the test suite by clicking on any of the tests in the list.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can now view individual [Test Results](test-results.md) executed by the test suite by clicking on any of the tests in the list.
You can now view individual [Test Results](test-results.md) executed by the Test Suite by clicking on any of the tests in the list.

@@ -1,10 +1,10 @@
# Undefined Variables

When a user runs a test or a transaction, any variables that will be needed but are not defined will be prompted for:
When a user runs a test or a test suite, any variables that will be needed but are not defined will be prompted for:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When a user runs a test or a test suite, any variables that will be needed but are not defined will be prompted for:
When a user runs a Test or a Test Suite, any variables that will be needed but are not defined will be prompted for:


![Undefined Variables Modal](../img/undefined-variables-modal.png)

Undefined variables are dependent on the environment selected and whether or not the variable is defined in the current environment. Select the environment to run the test or transaction in from the dropdown list at the top right of the page:
Undefined variables are dependent on the environment selected and whether or not the variable is defined in the current environment. Select the environment to run the test or test suite in from the dropdown list at the top right of the page:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Undefined variables are dependent on the environment selected and whether or not the variable is defined in the current environment. Select the environment to run the test or test suite in from the dropdown list at the top right of the page:
Undefined variables are dependent on the environment selected and whether or not the variable is defined in the current environment. Select the environment to run the Test or Test Suite in from the dropdown list at the top right of the page:

Copy link
Member

@jfermi jfermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some editing suggestions. I capitalized Test and Test Suite when referring to the Tracetest concepts that the doc is describing for clarity, but you can reject those if you don't think that is necessary.

@adnanrahic
Copy link
Contributor

@xoscar Can you add redirects to the links?

I see a lot of pages were renamed. We should add redirects in the docusaurus.config.js for everything that was changed.

tracetest apply testsuite -f <testsuite.yaml>
```

> If the file contains the property `spec.id`, the operation will be considered a Test Suite udpate.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update is not spelled correctly on this last line.


> :information_source: Outputs generated by steps don't modify the selected [variable set](./variable-sets.md). It only modifies the Test Suite run context object.

Consider you have 3 tests within a Test Suite: A, B, and C. Tests A and B generate outputs called A_OUTPUT and B_OUTPUT, respectively. When running the Test Suite, we provide a variable set which contains a `HOST` variable. The execution of test A would only be able to reference `env:HOST`. B would be able to reference `env:HOST`, and `env:A_OUTPUT`. While C would be able to reference all three variables: `env:HOST`, `env:A_OUTPUT`, `env:B_OUTPUT`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be referencing var:HOST, var:A_OUTPUT, etc here?

Copy link
Collaborator

@kdhamric kdhamric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Added a couple comments.

@xoscar xoscar merged commit 7eebb04 into main Aug 16, 2023
30 checks passed
@xoscar xoscar deleted the chore/transactions-to-test-suites-docs branch August 16, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants