Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump opentelemetry libraries to version v1.21.0 and collector to v0.80.0 #3195

Merged
merged 3 commits into from
Sep 29, 2023
Merged

chore: bump opentelemetry libraries to version v1.21.0 and collector to v0.80.0 #3195

merged 3 commits into from
Sep 29, 2023

Conversation

mathnogueira
Copy link
Member

@mathnogueira mathnogueira commented Sep 28, 2023 •
edited
Loading

This PR updates all opentelemetry libraries to the latest version but the collector which is set to 0.80.0 instead of 0.86.0. Ther reason is a bug that makes it impossible to use it for now:

../../../go/pkg/mod/go.opentelemetry.io/collector/confmap@v0.83.0/confmap.go:11:2: ambiguous import: found package github.com/knadh/koanf/maps in multiple modules:
        github.com/knadh/koanf v1.5.0 (/home/matheus/go/pkg/mod/github.com/knadh/koanf@v1.5.0/maps)
        github.com/knadh/koanf/maps v0.1.1 (/home/matheus/go/pkg/mod/github.com/knadh/koanf/maps@v0.1.1)
../../../go/pkg/mod/go.opentelemetry.io/collector/confmap@v0.83.0/confmap.go:12:2: ambiguous import: found package github.com/knadh/koanf/providers/confmap in multiple modules:
        github.com/knadh/koanf v1.5.0 (/home/matheus/go/pkg/mod/github.com/knadh/koanf@v1.5.0/providers/confmap)
        github.com/knadh/koanf/providers/confmap v0.1.0 (/home/matheus/go/pkg/mod/github.com/knadh/koanf/providers/confmap@v0.1.0)

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@mathnogueira mathnogueira changed the title chore: bump opentelemetry libraries to latest version chore: bump opentelemetry libraries to version v0.80.0 Sep 28, 2023
@mathnogueira mathnogueira changed the title chore: bump opentelemetry libraries to version v0.80.0 chore: bump opentelemetry libraries to version v1.21.0 and collector to v0.80.0 Sep 29, 2023
@mathnogueira mathnogueira marked this pull request as ready for review September 29, 2023 17:18
schoren
schoren reviewed Sep 29, 2023
View reviewed changes
server/main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file supposed to be here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No :P

@mathnogueira mathnogueira merged commit 373afc2 into main Sep 29, 2023
38 checks passed
@mathnogueira mathnogueira deleted the chore/bump-otel-libs branch September 29, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schoren schoren schoren approved these changes

@danielbdias danielbdias Awaiting requested review from danielbdias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathnogueira @schoren