Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): fix issues when running tests #3336

Merged
merged 4 commits into from
Nov 6, 2023
Merged

fix(server): fix issues when running tests #3336

merged 4 commits into from
Nov 6, 2023

Conversation

schoren
Copy link
Collaborator

@schoren schoren commented Nov 3, 2023

This PR fixes some issues when running tests.

  1. The test run cache was causing issues, and is no longer required, so it's removed.
  2. When mapping trigger results from openapi to internal models, an empty GRPC result was becoming an empty object instead of nil in the internal model, creating some confusion when handling results later
  3. The query to get the test suite run steps was using an incorrect sort field, causing the list to be in an unexpected order.

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

docker-compose.yaml Outdated Show resolved Hide resolved
@schoren schoren merged commit e4dd4a0 into main Nov 6, 2023
38 checks passed
@schoren schoren deleted the fix-runs branch November 6, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants