Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] configure cmd ask for target server #3585

Merged
merged 3 commits into from
Jan 31, 2024
Merged

[CLI] configure cmd ask for target server #3585

merged 3 commits into from
Jan 31, 2024

Conversation

schoren
Copy link
Collaborator

@schoren schoren commented Jan 31, 2024

This PR changes the behavior of the "configure" cli cmd. It now starts by asking for the desired target server, defaulting to the main cloud endpoint.

Changes

  • configure does not consider previous existing configuration
  • refactored code for better readability of the configure process
  • fix Makefile to correctly pass env vars to goreleaser

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/a5008e91749c494fa2ed991aa36877e6

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 2:10pm

@schoren schoren merged commit 9f7f26f into main Jan 31, 2024
39 checks passed
@schoren schoren deleted the config-improve branch January 31, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants