Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a multi-stage dockerfile to build console #1772

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented Apr 9, 2021

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
For some users who might don't have the NodeJs environment, it's not easy to build KubeSphere Console. So I provide a multi-stage Dockerfile, people just need to have a Docker environment.

Which issue(s) this PR fixes:
None.

Special notes for reviewers:
None.

Additional documentation, usage docs, etc.:
I already added the related document in the README file.

@ks-ci-bot ks-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2021
Signed-off-by: rick <1450685+LinuxSuRen@users.noreply.github.com>
@ks-ci-bot ks-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2021
@LinuxSuRen LinuxSuRen changed the title WIP: Add a multi-stage dockerfile to build console Add a multi-stage dockerfile to build console Apr 9, 2021
@ks-ci-bot ks-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2021
@LinuxSuRen
Copy link
Member Author

hi @kubesphere/sig-console and @harrisonliu5 , Please take a look at the improvement on the Docker Image build.

Dockerfile.multistage Outdated Show resolved Hide resolved
Signed-off-by: rick <1450685+LinuxSuRen@users.noreply.github.com>
@leoendless
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2021
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leoendless, LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2021
@ks-ci-bot ks-ci-bot merged commit 6a307ea into kubesphere:master Apr 12, 2021
@LinuxSuRen LinuxSuRen deleted the multistage branch April 12, 2021 09:29
ks-ci-bot pushed a commit that referenced this pull request Oct 23, 2023
fix: [devops 3.5] fix devops pipeline run log (#1772)

* fix: fix devops pipeline run log



* fix: update pipeline run log refresh icon



* fix: fix devops pipeline run log refresh action



* fix: fix devops history card name



---------

Signed-off-by: yazhou <yazhouhu@yunify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants