Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: User can't open container terminal #2702

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

weili520
Copy link
Contributor

@weili520 weili520 commented Dec 1, 2021

Signed-off-by: TheYoungManLi cjl@kubesphere.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

User can't enter ther container terminal page when the browser language is not en, zh and zh-tw

截屏2021-12-01 14 06 23

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

User can't enter ther container terminal page when the browser language is not en, zh and zh-tw.

Additional documentation, usage docs, etc.:

Signed-off-by: TheYoungManLi <cjl@kubesphere.io>
@ks-ci-bot ks-ci-bot added release-note kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2021
@harrisonliu5
Copy link
Contributor

/assign @xuliwenwenwen

@xuliwenwenwen
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2021
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 7f7313d7b61062494384f365fd3de85de43ecb48

@harrisonliu5
Copy link
Contributor

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, weili520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2021
@harrisonliu5
Copy link
Contributor

/cherry-pick release-3.2

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: once the present PR merges, I will cherry-pick it on top of release-3.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot merged commit 81b3300 into kubesphere:master Dec 2, 2021
@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: new pull request created: #2719

In response to this:

/cherry-pick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harrisonliu5
Copy link
Contributor

/cc @kubesphere/sig-testing

@weili520 weili520 deleted the local_language branch December 2, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants