Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the branch name not encode. #2753

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

harrisonliu5
Copy link
Contributor

Signed-off-by: harrisonliu5 harrisonliu@kubesphere.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##2747

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Signed-off-by: harrisonliu5 <harrisonliu@kubesphere.io>
@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2021
@harrisonliu5 harrisonliu5 changed the title fix: FIx the branch name not encode. fix: Fix the branch name not encode. Dec 6, 2021
@harrisonliu5
Copy link
Contributor Author

/area devops
/cc @kubesphere/sig-devops

@harrisonliu5
Copy link
Contributor Author

/assign @JohnNiang

@LinuxSuRen
Copy link
Member

hi @luoyuctl this is the front-end part of the git branch name-related issue. Feel free to help us to test it. Thanks!

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This fix works very well.

image

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harrisonliu5
Copy link
Contributor Author

/cherry-pick release-3.2

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: once the present PR merges, I will cherry-pick it on top of release-3.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xuliwenwenwen
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2021
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: e5876a744b85e10df65689f107cdd78653a40198

@ks-ci-bot ks-ci-bot merged commit ad4e55f into kubesphere:master Dec 6, 2021
@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: new pull request created: #2756

In response to this:

/cherry-pick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luoyuctl
Copy link

luoyuctl commented Dec 6, 2021

hi @luoyuctl this is the front-end part of the git branch name-related issue. Feel free to help us to test it. Thanks!

it has been verified that there is no problem, but there is still one last problem to fix . see kubesphere/ks-devops#400.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devops do-not-merge/release-note-label-needed kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants