Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add prompt information for button in log search detail page #2874

Merged
merged 1 commit into from
Dec 27, 2021

Conversation

weili520
Copy link
Contributor

@weili520 weili520 commented Dec 24, 2021

Signed-off-by: TheYoungManLi cjl@kubesphere.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##2850

Special notes for reviewers:

The tip works when the mouse hover

截屏2021-12-24 16 06 28

Does this PR introduced a user-facing change?

Add prompt information for button in log search detail page

Additional documentation, usage docs, etc.:

Signed-off-by: TheYoungManLi <cjl@kubesphere.io>
@ks-ci-bot ks-ci-bot added release-note kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 24, 2021
@zryfish
Copy link
Member

zryfish commented Dec 24, 2021

Are the tips always shown, or just when the mouse hovers?

@weili520
Copy link
Contributor Author

Are the tips always shown, or just when the mouse hovers?

It works when the mouse hover.

@weili520
Copy link
Contributor Author

/assign @xuliwenwenwen

@xuliwenwenwen
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 27, 2021
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 1bf69be858f893965dc49588d965c8762bd0b7ca

@harrisonliu5
Copy link
Contributor

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, weili520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2021
@ks-ci-bot ks-ci-bot merged commit 8290701 into kubesphere:master Dec 27, 2021
@weili520 weili520 deleted the button_tip branch April 22, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants