fix: Delete gpu field when editing project default resource #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ks-ci-bot
added
release-note
kind/bug
|
/test all |
|
/assign @xuliwenwenwen |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 5b5ed85560dc44c88be779198d17d3c0f560a74c
|
Signed-off-by: TheYoungManLi <cjl@kubesphere.io>
weili520
force-pushed
the
delete_resource_deault_gpu
branch
from
588c804 to
721e3e4
Compare
|
@xuliwenwenwen I have resolved conflicts, please review them again, thanks a lot. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 46ff26ff2a6fe33d805d3760c2ff4e798f13b6f7
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harrisonliu5, weili520 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TheYoungManLi cjl@kubesphere.io
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes ##2870
Special notes for reviewers:
Add GPU limit info
delete GPU field
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.:
This one should be merged after #2878, and it will need to resolve conflicts.