Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete gpu field when creating workload #2895

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

weili520
Copy link
Contributor

@weili520 weili520 commented Jan 6, 2022

Signed-off-by: TheYoungManLi cjl@kubesphere.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##2870

Special notes for reviewers:

Create a deployment, and then switch to edit YAML mode

截屏2022-01-06 17 01 30

Does this PR introduced a user-facing change?

Use kubectl to apply the YAML which is copied from the deployments detail page failed.

Additional documentation, usage docs, etc.:

Signed-off-by: TheYoungManLi <cjl@kubesphere.io>
@ks-ci-bot ks-ci-bot added release-note kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 6, 2022
@weili520
Copy link
Contributor Author

weili520 commented Jan 6, 2022

/assign @xuliwenwenwen

@xuliwenwenwen
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 45bd9847297d0019a1e6eef1ee33e1e06a29784d

@harrisonliu5
Copy link
Contributor

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, weili520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2022
@harrisonliu5
Copy link
Contributor

/cc @kubesphere/sig-testing

@ks-ci-bot ks-ci-bot merged commit 9cf415d into kubesphere:master Jan 7, 2022
@weili520 weili520 deleted the delete_create_workload_gpu branch April 22, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants