-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting the hostpath is required when mounting the hostpath storage volume to an application #3411
Conversation
Hi @zhaohuiweixiao. Thanks for your PR. I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc zheng1 |
/cc @harrisonliu5 |
Thanks for your contribution! |
could you review the code for me? @harrisonliu5 |
/ok-to-test |
@zhaohuiweixiao please modify the Git commit messages following the Conventional Commits 1.0.0, Thanks. |
d858bb1
to
b95d194
Compare
@harrisonliu5 the commit message has been modified. |
…age volume to an application Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com>
b95d194
to
e7af30f
Compare
/assign @weili520 |
/lgtm |
LGTM label has been added. Git tree hash: 2ae35c5374cf25988adbe925cf1512e920f0420a
|
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harrisonliu5, zhaohuiweixiao, zheng1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-3.3 |
@harrisonliu5: new pull request created: #3478 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: zhaohuihui zhaohuihui_yewu@cmss.chinamobile.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
During the creation of a homemade application, when the hostpath storage volume type is mounted, an error message(Deployment.apps "ss-v1" is invalid: [spec.template.spec.volumes[0].hostPath.path: Required value, spec.template.spec.containers[0].volumeMounts[0].name: Not found: "test-zhh"]) is displayed if the hostpath is not specified. If the hostpath is specified, the application is successfully created.
On the other hand, I looked up the Kubernetes API documentation(https://kubernetes.io/docs/concepts/storage/volumes/#hostpath) and the host path is a property that must be set .
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: