Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the hostpath is required when mounting the hostpath storage volume to an application #3411

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

zhaohuiweixiao
Copy link
Member

@zhaohuiweixiao zhaohuiweixiao commented Jun 22, 2022

Signed-off-by: zhaohuihui zhaohuihui_yewu@cmss.chinamobile.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

  1. During the creation of a homemade application, when the hostpath storage volume type is mounted, an error message(Deployment.apps "ss-v1" is invalid: [spec.template.spec.volumes[0].hostPath.path: Required value, spec.template.spec.containers[0].volumeMounts[0].name: Not found: "test-zhh"]) is displayed if the hostpath is not specified. If the hostpath is specified, the application is successfully created.
    hostpath_error

  2. On the other hand, I looked up the Kubernetes API documentation(https://kubernetes.io/docs/concepts/storage/volumes/#hostpath) and the host path is a property that must be set .
    image

Special notes for reviewers:

/assign @zheng1

Does this PR introduced a user-facing change?

Setting the hostpath is required when mounting the hostpath storage volume to an application 

Additional documentation, usage docs, etc.:

Setting the hostpath is required when mounting the hostpath storage volume to an application 

@ks-ci-bot ks-ci-bot added release-note kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Jun 22, 2022
@ks-ci-bot
Copy link
Collaborator

Hi @zhaohuiweixiao. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhaohuiweixiao
Copy link
Member Author

/cc zheng1

@ks-ci-bot ks-ci-bot requested a review from zheng1 June 22, 2022 09:47
@zheng1
Copy link
Member

zheng1 commented Jun 23, 2022

/cc @harrisonliu5

@ks-ci-bot ks-ci-bot requested a review from harrisonliu5 June 23, 2022 02:59
@harrisonliu5
Copy link
Contributor

Thanks for your contribution!

@zhaohuiweixiao
Copy link
Member Author

Thanks for your contribution!

could you review the code for me? @harrisonliu5

@harrisonliu5
Copy link
Contributor

/ok-to-test

@harrisonliu5
Copy link
Contributor

@zhaohuiweixiao please modify the Git commit messages following the Conventional Commits 1.0.0, Thanks.

@zhaohuiweixiao
Copy link
Member Author

@zhaohuiweixiao please modify the Git commit messages following the Conventional Commits 1.0.0, Thanks.

@harrisonliu5 the commit message has been modified.

…age volume to an application

Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com>
@harrisonliu5
Copy link
Contributor

/assign @weili520

@weili520
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 2ae35c5374cf25988adbe925cf1512e920f0420a

@harrisonliu5
Copy link
Contributor

/approve

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@zheng1 zheng1 added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 13, 2022
@zheng1
Copy link
Member

zheng1 commented Jul 13, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, zhaohuiweixiao, zheng1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [harrisonliu5,zheng1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@ks-ci-bot ks-ci-bot merged commit 16de4d6 into kubesphere:master Jul 13, 2022
@harrisonliu5
Copy link
Contributor

/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: new pull request created: #3478

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants