Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The node terminal is always showing connecting status #3447

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

weili520
Copy link
Contributor

@weili520 weili520 commented Jul 18, 2022

Signed-off-by: TheYoungManLi cjl@kubesphere.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##4950

Special notes for reviewers:

2022-07-18.16.24.27.mov

Does this PR introduced a user-facing change?

NONE

Additional documentation, usage docs, etc.:


Signed-off-by: TheYoungManLi <cjl@kubesphere.io>
@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 18, 2022
@harrisonliu5
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: c8ba6e4ea45840ff9479b264b94f652d023df778

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, weili520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2022
@harrisonliu5 harrisonliu5 merged commit 34db0e5 into kubesphere:master Jul 18, 2022
@harrisonliu5
Copy link
Contributor

/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: new pull request could not be created: failed to create pull request against kubesphere/console#release-3.3 from head ks-ci-bot:cherry-pick-3447-to-release-3.3: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits"}

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@weili520 weili520 deleted the kubectl_connecting branch September 26, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants