Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The gidMax and gidMin in the storage class GlusterFs are not format checked #3467

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

weili520
Copy link
Contributor

@weili520 weili520 commented Jul 27, 2022

Signed-off-by: TheYoungManLi cjl@kubesphere.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##3463

Special notes for reviewers:

截屏2022-07-27 17 34 51

Does this PR introduced a user-facing change?

NONE

Additional documentation, usage docs, etc.:


@weili520 weili520 added the kind/require-ui-text-review Indicates that the UI text needs to be reviewed by the technical writing team. label Jul 27, 2022
…mat checked

Signed-off-by: TheYoungManLi <cjl@kubesphere.io>
@ks-ci-bot ks-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/need-to-verify labels Jul 27, 2022
@harrisonliu5
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, weili520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: a4801d7827145696511a0d7d46292dbe488a286a

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@harrisonliu5 harrisonliu5 merged commit 3c1c29d into kubesphere:master Jul 28, 2022
@harrisonliu5
Copy link
Contributor

/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: new pull request created: #3505

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@weili520 weili520 deleted the gidmax_valid branch September 26, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/require-ui-text-review Indicates that the UI text needs to be reviewed by the technical writing team. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants