fix: Avoid the being deleting Pipelines on the list page #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bunny <qimiao@yunify.com>
ks-ci-bot
added
release-note-none
kind/bug
|
/area devops |
LinuxSuRen
reviewed
Aug 3, 2022
|
LGTM label has been added. Git tree hash: bfd583a3cdb8eebc6403d7cedefc5c751ed915bd
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bunnymiao, harrisonliu5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
the
approved
harrisonliu5
pushed a commit
that referenced
this pull request
Oct 17, 2023
* refactor: Avoid using API tojson and tojenkinsfile (#3450) * refactor: Avoid using API tojson and tojenkinsfile Signed-off-by: Bunny <qimiao@yunify.com> * perf: Disable the Edit JenkinsFile button in pipeline details page Signed-off-by: Bunny <qimiao@yunify.com> * fix: Fix the bug that the jenkinsfile value is undefiend when first edit pipeline Signed-off-by: Bunny <qimiao@yunify.com> * feat: Bypass the script compile check when the api call fails Signed-off-by: Bunny <qimiao@yunify.com> * refactor: Remove the notify when checkScripCompile api call fails and add tooltips for disabled button that edit jenkinsfile Signed-off-by: Bunny <qimiao@yunify.com> Co-authored-by: Bunny <qimiao@yunify.com> * fix: Avoid the being deleting Pipelines on the list page (#3513) Signed-off-by: Bunny <qimiao@yunify.com> Co-authored-by: Bunny <qimiao@yunify.com> * fix: When 'jenkinsfile.edit.mode' is json, show the pipeline (#4099) * feat: When 'jenkinsfile.edit.mode' is json, show the pipeline Signed-off-by: 胡亚洲 <git@yazhou.io> * fix: fix jenkins validate status Signed-off-by: 胡亚洲 <git@yazhou.io> * fix: add timer in pipeline detail page Signed-off-by: 胡亚洲 <git@yazhou.io> --------- Signed-off-by: 胡亚洲 <git@yazhou.io> --------- Signed-off-by: 胡亚洲 <git@yazhou.io> Co-authored-by: Bunny miao <49241072+bunnymiao@users.noreply.github.com> Co-authored-by: Bunny <qimiao@yunify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bunny qimiao@yunify.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
Filter the being deleting Pipelines in the pipeline list
Which issue(s) this PR fixes:
Fixes #736
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: