Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add empty message in image builder create modal #3524

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

harrisonliu5
Copy link
Contributor

@harrisonliu5 harrisonliu5 commented Aug 3, 2022

Signed-off-by: harrisonliu5 harrisonliu@kubesphere.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

image

Does this PR introduced a user-facing change?

fix: Add empty message in image builder create modal

Additional documentation, usage docs, etc.:


Signed-off-by: harrisonliu5 <harrisonliu@kubesphere.io>
@harrisonliu5 harrisonliu5 added the kind/require-ui-text-review Indicates that the UI text needs to be reviewed by the technical writing team. label Aug 3, 2022
@ks-ci-bot ks-ci-bot added release-note kind/bug Categorizes issue or PR as related to a bug. labels Aug 3, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 3, 2022
@harrisonliu5
Copy link
Contributor Author

/cc @kubesphere/sig-testing

@harrisonliu5
Copy link
Contributor Author

/assign @weili520

@harrisonliu5
Copy link
Contributor Author

/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@weili520
Copy link
Contributor

weili520 commented Aug 3, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 26f8dc153df6f5101ed0b772379c54f24d4e1edf

@LinuxSuRen
Copy link
Member

/area devops

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: new pull request created: #3534

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devops kind/bug Categorizes issue or PR as related to a bug. kind/require-ui-text-review Indicates that the UI text needs to be reviewed by the technical writing team. lgtm Indicates that a PR is ready to be merged. release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants