Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support CD directory recurse #3558

Merged

Conversation

EliChen95
Copy link
Contributor

Signed-off-by: elichen95 elichen95@163.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

image

Does this PR introduced a user-facing change?

feat: Support CD directory recurse

Additional documentation, usage docs, etc.:


Signed-off-by: elichen95 <elichen95@163.com>
@ks-ci-bot ks-ci-bot added release-note kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 11, 2022
@EliChen95
Copy link
Contributor Author

/area devops

Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it manually. It works well.
/lgtm

kubespheredev/ks-console:feat-support-directory-recurse

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: eb4087b58e6f08c68a2d0a47669e282de5a86eac

@harrisonliu5
Copy link
Contributor

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EliChen95, harrisonliu5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2022
@harrisonliu5 harrisonliu5 merged commit 982a705 into kubesphere:master Aug 12, 2022
LinuxSuRen added a commit to kubesphere-sigs/ks-infra that referenced this pull request Aug 16, 2022
LinuxSuRen added a commit to kubesphere-sigs/ks-infra that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devops kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants