Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing openelb annotation hint when editing service of type loadbalancer #3578

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

weili520
Copy link
Contributor

@weili520 weili520 commented Aug 18, 2022

Signed-off-by: TheYoungManLi cjl@kubesphere.io

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##5006

Special notes for reviewers:

截屏2022-08-18 17 54 13

Does this PR introduced a user-facing change?

NONE

Additional documentation, usage docs, etc.:


…lancer

Signed-off-by: TheYoungManLi <cjl@kubesphere.io>
@ks-ci-bot ks-ci-bot added release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 18, 2022
@harrisonliu5
Copy link
Contributor

/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harrisonliu5
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 858def3400f466fb724cc2d1bc6f9f6ba1a6067f

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, weili520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2022
@ks-ci-bot ks-ci-bot merged commit d8b19ca into kubesphere:master Aug 19, 2022
@ks-ci-bot
Copy link
Collaborator

@harrisonliu5: new pull request created: #3582

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@weili520 weili520 deleted the service_openelb_edit branch September 26, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants