Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimization the image building of KubeSphere/console #3591

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

zt1046656665
Copy link
Contributor

@zt1046656665 zt1046656665 commented Aug 19, 2022

Signed-off-by: zhoutian zhoutian@yunify.com

What type of PR is this?

What this PR does / why we need it:

we can build image easily by this PR.
when to webpack to get the javascript file,its will cost much time in linux/arm64, so we just get the javascript file in linux/amd64,and then build the final images in linux/amd64or linux/arm64.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

optimization the image building of KubeSphere/console

Does this PR introduced a user-facing change?

first we build the pre-image to get the file by webpacking
then we can build the image of linux/amd64,linux/arm64  by copy the file
finally we will rmi the pre-image and rm the file by webpacking

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added release-note needs-ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2022
@ks-ci-bot
Copy link
Collaborator

Hi @zt1046656665. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

build/Dockerfile.dapper Outdated Show resolved Hide resolved
@zt1046656665 zt1046656665 force-pushed the master branch 5 times, most recently from 30bbd74 to f094ff7 Compare August 23, 2022 09:51
Signed-off-by: zhoutian <zhoutian@yunify.com>
@pixiake
Copy link
Contributor

pixiake commented Aug 25, 2022

/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@pixiake: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harrisonliu5
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 72a55b1fad33bae2aeb9531492dcbc9a9e41e72d

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, zt1046656665

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
@ks-ci-bot ks-ci-bot merged commit 6d29fbf into kubesphere:master Aug 25, 2022
@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #3610

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Leioy pushed a commit to Leioy/console that referenced this pull request Sep 25, 2024
Signed-off-by: zhoutian <zhoutian@yunify.com>

Signed-off-by: zhoutian <zhoutian@yunify.com>
Co-authored-by: zhoutian <zhoutian@yunify.com>
(cherry picked from commit 6d29fbf)
Leioy pushed a commit to Leioy/console that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants