Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.3] fix: misbehaving when editing the same name service #3696

Merged

Conversation

ks-ci-bot
Copy link
Collaborator

This is an automated cherry-pick of #3688

feat: add duplicate name validation to the service name

Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com>
@ks-ci-bot ks-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 13, 2022
@harrisonliu5
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@ks-ci-bot
Copy link
Collaborator Author

LGTM label has been added.

Git tree hash: f2735df03779671201a5efcd3bf9814f6df2953a

@ks-ci-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, ks-ci-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2022
@ks-ci-bot ks-ci-bot merged commit faaa20c into kubesphere:release-3.3 Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. release-note release-notes-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants