Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix pipeline shell command can't save #4206

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: Fix pipeline shell command can't save #4206

merged 1 commit into from
Oct 18, 2023

Conversation

yazhouio
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: Fix pipeline shell params can't save

Which issue(s) this PR fixes:

Fixes #https://github.com/kubesphere/issues/issues/2050
Fixes #kubesphere/kubesphere#5902

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: yazhou <yazhouhu@yunify.com>
@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2023
@yazhouio yazhouio changed the title fix: Fix pipeline shell params can't save fix: Fix pipeline shell command can't save Oct 18, 2023
@harrisonliu5
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 6842e0f9619548b7a666822892cb6b4661ccb8c8

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, yazhouio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@ks-ci-bot ks-ci-bot merged commit 4067c95 into kubesphere:master Oct 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants