Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the text description of deleting expired branches in a multi-branch pipeline setup is inaccurate. #4223

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

yazhouio
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

fix: Fix the text description of deleting expired branches in a multi-branch pipeline setup is inaccurate.

Which issue(s) this PR fixes:

Fixes #kubesphere/ks-devops#971

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: yazhou <yazhouhu@yunify.com>
@ks-ci-bot ks-ci-bot added release-note-none kind/documentation Categorizes issue or PR as related to documentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2023
Signed-off-by: yazhou <yazhouhu@yunify.com>
@harrisonliu5
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 061007bf59f040d6ec95ab330a80dd640951fe68

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, yazhouio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@ks-ci-bot ks-ci-bot merged commit 5dbc288 into kubesphere:master Oct 23, 2023
3 checks passed
ks-ci-bot pushed a commit that referenced this pull request Nov 3, 2023
… a multi-branch pipeline setup is inaccurate." (#4248)

Revert "fix: Fix the text description of deleting expired branches in a multi-branch pipeline setup is inaccurate. (#4223)"

This reverts commit 5dbc288.
ks-ci-bot pushed a commit to ks-ci-bot/console that referenced this pull request Nov 3, 2023
… a multi-branch pipeline setup is inaccurate. (kubesphere#4223)"

This reverts commit 5dbc288.
harrisonliu5 pushed a commit that referenced this pull request Nov 6, 2023
…ed branches in a multi-branch pipeline setup is inaccurate." (#4250)

Revert "fix: Fix the text description of deleting expired branches in a multi-branch pipeline setup is inaccurate. (#4223)"

This reverts commit 5dbc288.

Co-authored-by: 古月 <git@yazhou.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants