Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter clusters by status of ready in kubectl modal #4317

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

yazhouio
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

image

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

none

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2024
@yazhouio yazhouio changed the title fix: Filter clusters by status of ready in kubectl modal WIP: fix: Filter clusters by status of ready in kubectl modal Sep 25, 2024
@ks-ci-bot ks-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2024
Signed-off-by: yazhou <yazhouhu@yunify.com>
@yazhouio yazhouio changed the title WIP: fix: Filter clusters by status of ready in kubectl modal fix: Filter clusters by status of ready in kubectl modal Sep 25, 2024
@ks-ci-bot ks-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2024
@donniean
Copy link
Contributor

/lgtm

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donniean, yazhouio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 4dadb3ca1be7af623b8598e2c104d151b0c0a7b1

@ks-ci-bot ks-ci-bot merged commit cd70c1d into kubesphere:master Sep 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants