-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the API for getting devops project #435
Fix the API for getting devops project #435
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LinuxSuRen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm not sure if there are other purposes for this API. So I will do more tests on it. |
Codecov Report
@@ Coverage Diff @@
## master kubesphere/console#435 +/- ##
==========================================
+ Coverage 75.46% 76.69% +1.22%
==========================================
Files 108 108
Lines 22314 22022 -292
==========================================
+ Hits 16840 16889 +49
+ Misses 5309 4960 -349
- Partials 165 173 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
620fb93
to
0740803
Compare
/unhold |
0740803
to
1ef78b9
Compare
/hold |
1ef78b9
to
a2fb9c9
Compare
/unhold Some changes for API
|
func (h *devopsHandler) GetDevOpsProject(request *restful.Request, response *restful.Response) { | ||
workspace := request.PathParameter("workspace") | ||
devops := request.PathParameter("devops") | ||
devopsProject := request.PathParameter("devops") | ||
generateNameFlag := request.QueryParameter("generateName") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary. We can use xx == 'true'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently, the UI try to use this API to find if the desired name is duplicated. But for DevOpsProject, we should use the generateName instead of the resource real name.
Which issue(s) this PR fixes:
Fixes #
This PR should be able to fix part of #635
Special notes for reviewers:
Does this PR introduce a user-facing change??
Test results
/cc @kubesphere/sig-devops