Install ks-core with helm chart #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ks-ci-bot
added
kind/feature
RolandMa1986
changed the title
ks-ci-bot
added
do-not-merge/work-in-progress
|
/cc @yuswift @pixiake |
|
Cool! Looks like our dream will come to true soon. |
|
I will add some initial custom resources when installing ks-core with helm. |
|
/reopen |
RolandMa1986
changed the title
ks-ci-bot
removed
the
do-not-merge/work-in-progress
swiftslee
reviewed
Jun 2, 2021
| - ks_svc.stdout.find("ks-console") != -1 | ||
| shell: > | ||
| {{ bin_dir }}/helm upgrade --install ks-core | ||
| {{ kubesphere_dir }}/ks-core/ks-core-0.1.0.tgz |
There was a problem hiding this comment.
Could you put charts dir here instead of a .tgz file?
There was a problem hiding this comment.
I agree to @yuswift's proposal.
Using charts may be more convenient for everyone to maintain.
added 5 commits
June 15, 2021 08:19
Signed-off-by: Roland.Ma <rolandma@yunify.com>
Signed-off-by: Roland.Ma <rolandma@yunify.com>
Signed-off-by: Roland.Ma <rolandma@yunify.com>
Signed-off-by: Roland.Ma <rolandma@yunify.com>
Signed-off-by: Roland.Ma <rolandma@yunify.com>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pixiake, RolandMa1986 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roland.Ma rolandma@yunify.com
/kind feature
type: NodePortfor console.kubesphere/kubesphere#3847