Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete globalrole workspace-manager #2094

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Delete globalrole workspace-manager #2094

merged 1 commit into from
Sep 15, 2022

Conversation

zhou1203
Copy link
Member

Delete globalrole workspace-manager and disable role-template-manage-workspaces for custom roles

Signed-off-by: Wenhao Zhou wenhaozhou@yunify.com

@zhou1203
delete globalrole workspace-manager and disable role-template-manage-…
f0ca274 
…workspaces for custom roles

Signed-off-by: Wenhao Zhou <wenhaozhou@yunify.com>
@ks-ci-bot ks-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 31, 2022
@zhou1203
Copy link
Member Author

/cc @wansir @pixiake

@ks-ci-bot ks-ci-bot requested review from pixiake and wansir August 31, 2022 07:30
@wansir
Copy link
Member

wansir commented Aug 31, 2022

/lgtm
/approve

/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@wansir: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/lgtm
/approve

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: ba58858fcada0bec7b1ffbd69dce03ae9a9e16b2

@pixiake
Copy link
Collaborator

pixiake commented Sep 15, 2022

/approve
/lgtm

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, wansir, zhou1203

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022
@ks-ci-bot ks-ci-bot merged commit 82a3784 into kubesphere:master Sep 15, 2022
@ks-ci-bot ks-ci-bot mentioned this pull request Sep 15, 2022
Merged
@ks-ci-bot
Copy link
Collaborator

@wansir: new pull request created: #2104

In response to this:

/lgtm
/approve

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixiake pixiake Awaiting requested review from pixiake

@wansir wansir Awaiting requested review from wansir

Assignees

@wansir wansir

@pixiake pixiake

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhou1203 @wansir @ks-ci-bot @pixiake