Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete clusterRoles #2122

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Delete clusterRoles #2122

merged 1 commit into from
Oct 12, 2022

Conversation

zhou1203
Copy link
Member

@zhou1203 zhou1203 commented Sep 30, 2022 •
edited
Loading

delete clusterRoles for configmap, secret, serviceaccount and aggregating them to project resources management

Signed-off-by: Wenhao Zhou wenhaozhou@yunify.com

@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 30, 2022
@zhou1203 zhou1203 changed the title delete clusterRoles for configmap, secret, serviceaccount and aggrega… Delete clusterRoles Sep 30, 2022
@zhou1203
Copy link
Member Author

/cc @wansir @pixiake

@ks-ci-bot ks-ci-bot requested review from pixiake and wansir September 30, 2022 03:06
@zhou1203 zhou1203 mentioned this pull request Sep 30, 2022
Closed
@zhou1203
delete clusterRoles for configmap, secret, serviceaccount and aggrega…
69c42b0 
…ting them to project resources management

Signed-off-by: Wenhao Zhou <wenhaozhou@yunify.com>
@zhou1203
Copy link
Member Author

/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@zhou1203: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wansir
Copy link
Member

wansir commented Sep 30, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 16955d17638e1f7507c716d0feb1cb721a59c420

@pixiake
Copy link
Collaborator

pixiake commented Sep 30, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, zhou1203

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@ks-ci-bot ks-ci-bot merged commit 544a1ec into kubesphere:master Oct 12, 2022
@ks-ci-bot ks-ci-bot mentioned this pull request Oct 12, 2022
Merged
@ks-ci-bot
Copy link
Collaborator

@zhou1203: new pull request created: #2126

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixiake pixiake Awaiting requested review from pixiake

@wansir wansir Awaiting requested review from wansir

Assignees

@wansir wansir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhou1203 @ks-ci-bot @wansir @pixiake