Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kubernetes v1.24.1 and other new versions #1306

Closed
brandan-schmitz opened this issue Jun 1, 2022 · 6 comments · Fixed by #1307
Closed

Support Kubernetes v1.24.1 and other new versions #1306

brandan-schmitz opened this issue Jun 1, 2022 · 6 comments · Fixed by #1307
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request

Comments

@brandan-schmitz
Copy link
Contributor

Your current KubeKey version

v2.1.1

Describe this feature

Kubernetes recently released a new round of updates on May 24th, 2022:

  • v1.21.13
  • v1.22.10
  • v1.23.7
  • v1.24.1

Describe the solution you'd like

Add the ability to use these versions with the --with-kubernetes flag. Currently they cannot be used as the sha256 checksum and version is not in the application.

Additional information

No response

@brandan-schmitz brandan-schmitz changed the title Support Kubernetes v1.24.1 and 1.23.7 Support Kubernetes v1.24.1 and other new versions Jun 1, 2022
@24sama
Copy link
Collaborator

24sama commented Jun 1, 2022

/kind feature-request

@24sama
Copy link
Collaborator

24sama commented Jun 1, 2022

Hi @brandan-schmitz , thanks for your feedback!
Support more Kubernetes versions are very necessary.
I think this fits as a "good-first-issue" so if you're interested in fixing it, please let me know.

/good-first-issue

@ks-ci-bot
Copy link
Collaborator

@24sama:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Hi @brandan-schmitz , thanks for your feedback!
Support more Kubernetes versions are very necessary.
I think this fits as a "good-first-issue" so if you're interested in fixing it, please let me know.

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 1, 2022
@brandan-schmitz
Copy link
Contributor Author

@24sama I would be be willing to work on this, what is the process that has been used for obtaining the checksum currently used in the project? I compared some of them to the checksums listed at https://www.downloadkubernetes.com/ (linked in the official k8s documentation) however they do not seem to match.

I also see that currently it pulls from a google storage account, however when I go to the links as I would expect them to be based on the contents of pkg/files/file.go it is unable to locate the files.

@24sama
Copy link
Collaborator

24sama commented Jun 1, 2022

Hi @brandan-schmitz
For now, kk need to add the sha256 into pkg/files/file.go, it's really not elegant and flexible.
So we need to increase this map

FileSha256 = map[string]map[string]map[string]string{

And I think you can get the sha256 checksum by the following link, this comes from the official doc: https://kubernetes.io/docs/tasks/tools/install-kubectl-linux/

Example:

# amd64
https://storage.googleapis.com/kubernetes-release/release/v1.24.1/bin/linux/amd64/kubectl.sha256
https://storage.googleapis.com/kubernetes-release/release/v1.24.1/bin/linux/amd64/kubelet.sha256
https://storage.googleapis.com/kubernetes-release/release/v1.24.1/bin/linux/amd64/kubeadm.sha256

# arm64
https://storage.googleapis.com/kubernetes-release/release/v1.24.1/bin/linux/arm64/kubectl.sha256
https://storage.googleapis.com/kubernetes-release/release/v1.24.1/bin/linux/arm64/kubelet.sha256
https://storage.googleapis.com/kubernetes-release/release/v1.24.1/bin/linux/arm64/kubeadm.sha256

After that we need to add some new elements to this array and the docs:

func SupportedK8sVersionList() []string {

https://github.com/kubesphere/kubekey/blob/master/docs/kubernetes-versions.md

@brandan-schmitz
Copy link
Contributor Author

@24sama I have created a PR that adds all the versions of Kubernetes that were missing starting with version 1.21.0 as that is the oldest currently supported version. The PR has been linked to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants