Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zombie process crontab #1169

Merged
merged 1 commit into from
Apr 10, 2022
Merged

Conversation

yuzhiquan
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Remove zombie process crontab, in some situation, this cron will kill dockershim and make pod recreated

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

NONE

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2022
@pixiake
Copy link
Collaborator

pixiake commented Apr 2, 2022

Can you describe the situation in detail? Thanks
dockershim was killed by this cronjob, is it because the docker service is not normal?

@yuzhiquan
Copy link
Contributor Author

Can you describe the situation in detail? Thanks dockershim was killed by this cronjob, is it because the docker service is not normal?

If some pod in cluster create zombie process,and doesnot handle it, then grep ppid will lead to the dockershim process, that's happening in our online cluster!

@pixiake
Copy link
Collaborator

pixiake commented Apr 8, 2022

Can we get around it by adding filter conditions to this command?
such as: ps -A -ostat,ppid,cmd | grep -v *shim* | grep -e '^[Zz]' | awk '{print $2}' | xargs kill -HUP > /dev/null 2>&1"

@yuzhiquan
Copy link
Contributor Author

Can we get around it by adding filter conditions to this command? such as: ps -A -ostat,ppid,cmd | grep -v *shim* | grep -e '^[Zz]' | awk '{print $2}' | xargs kill -HUP > /dev/null 2>&1"

May be the fix can avoid this issue, but z process does not affect in many situation, so i'm not sure if flannel or dns pod make z process, for example, this cmd can handle these?

@pixiake
Copy link
Collaborator

pixiake commented Apr 10, 2022

Can we get around it by adding filter conditions to this command? such as: ps -A -ostat,ppid,cmd | grep -v *shim* | grep -e '^[Zz]' | awk '{print $2}' | xargs kill -HUP > /dev/null 2>&1"

May be the fix can avoid this issue, but z process does not affect in many situation, so i'm not sure if flannel or dns pod make z process, for example, this cmd can handle these?

Yes, some zombie processes may be killed by mistake.

@pixiake
Copy link
Collaborator

pixiake commented Apr 10, 2022

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 3f041b2cecc2fbd64632f1c7172b35ff3c5b78b1

@pixiake
Copy link
Collaborator

pixiake commented Apr 10, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, yuzhiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2022
@ks-ci-bot ks-ci-bot merged commit 72f3727 into kubesphere:master Apr 10, 2022
@yuzhiquan yuzhiquan deleted the remove-z branch April 11, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants