fix sudo not work expected #1197
Conversation
ks-ci-bot
added
kind/bug
| @@ -62,10 +70,7 @@ func (n *NodePreCheck) Execute(runtime connector.Runtime) error { | |||
| if err != nil || strings.Contains(res, "not found") { | |||
| results[software] = "" | |||
| } else { | |||
| if strings.HasPrefix(cmd, "which") { | |||
There was a problem hiding this comment.
Sorry, I don't know why should modify here. Here, the result of docker and containerd will show their version.
|
Hi @yinheli |
|
Hi @yinheli Thanks again! |
|
@24sama Got |
while sudo package not installed, precheck not work expected kubesphere#1196
yinheli
force-pushed
the
yinheli/develop
branch
from
e0a1fb6
to
32e5918
Compare
|
@24sama Done, Thanks for your review. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: b105dca4932151912ae5d1927c9c0940830878f2
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 24sama, yinheli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
the
approved
|
@all-contributors please add @yinheli for code |
|
I've put up a pull request to add @yinheli! 🎉 |
While sudo package not installed, precheck not work expected.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1196
Special notes for reviewers:
prepare test env:
Does this PR introduced a user-facing change?