Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix containerd does not apply insecureRegistries in config.toml #1271

Merged
merged 1 commit into from
May 9, 2022

Conversation

hellocn9
Copy link
Contributor

@hellocn9 hellocn9 commented May 9, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix containerd does not apply insecureRegistries in config.toml

Which issue(s) this PR fixes:

Fixes #1268 #1270

@ks-ci-bot ks-ci-bot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2022
@hellocn9
Copy link
Contributor Author

hellocn9 commented May 9, 2022

/assign @24sama

@24sama
Copy link
Collaborator

24sama commented May 9, 2022

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 5c92de307705e5a6d9cc0c7d3aed3c3e1718d49a

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama, hellocn9

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2022
@ks-ci-bot ks-ci-bot merged commit ae9790a into kubesphere:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When use containerd as container runtime, containerd does not apply the configuration of insecureRegistrys.
3 participants