Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support harbor automatically start #1302

Merged
merged 1 commit into from
May 27, 2022

Conversation

Feeeenng
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

/kind feature

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:

if use kubekey install harbor, the package should be include "install.sh" sciprts,
the scripts can let harbor auto start, the command  `docker-compose up -d`
but it is not start, the reason is Compose does not wait until a container is “ready”.
the document  https://docs.docker.com/compose/startup-order/

@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2022
@24sama
Copy link
Collaborator

24sama commented May 27, 2022

Hi @Feeeenng
Thanks for your contribution!

@24sama
Copy link
Collaborator

24sama commented May 27, 2022

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 53b459082ec6c44811bcd401eba20c245bfcbc53

@24sama
Copy link
Collaborator

24sama commented May 27, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama, Feeeenng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2022
@ks-ci-bot ks-ci-bot merged commit b19724c into kubesphere:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants