-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: GreetingModule sometimes occurs a timeout error #1371
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 24sama The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I just changed the option from Timeout: 30 * time.Second, to Timeout: 800 * time.Second, in kubekey/pkg/bootstrap/precheck/module.go (but you may set any time) |
This is also a hardcode and maybe it doesn't work when the number of This PR will automatically increase the
The task
The task
The task |
Signed-off-by: 24sama <jacksama@foxmail.com>
/lgtm |
LGTM label has been added. Git tree hash: 849d5f213b0aa7e8d5e9c552a020d43da4022ab5
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
For now, the
timeout
value of theGreetingModule
will be calculated by adding up thetimeout
values of all hostsWhich issue(s) this PR fixes:
Fixes #1288
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: