support docker's data-root config #1375
Conversation
ks-ci-bot
added
the
size/M
pkg/kubernetes/module.go
Outdated
| Prepare: new(common.OnlyFirstMaster), | ||
| Action: new(DrainNode), | ||
| Retry: 2, | ||
| IgnoreError: true, |
There was a problem hiding this comment.
The functionality of this IgnoreError field is not yet implemented. So if there are some errors, the result will not be what you expected.
There was a problem hiding this comment.
We want to ignore the error. Can we reserve it
There was a problem hiding this comment.
Just do not return the error in the Action.
Example:
_, _ := runtime.GetRunner().SudoCmd("xxxx")
There was a problem hiding this comment.
ok,I deleted this field
|
Hi, @wenwutang1 Thanks for your contribution! |
ks-ci-bot
added
size/S
2. add timeout and ignore error when drain node Signed-off-by: wwt <wenwutang@yunify.com>
|
/lgtm |
|
LGTM label has been added. Git tree hash: 860ec9b80a6b33d53b6fee369aec9914c709d98d
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 24sama, wenwutang1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
the
approved
|
@all-contributors please add @wenwutang1 for code |
|
I've put up a pull request to add @wenwutang1! 🎉 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This pr is to provide data-root config when cni is docker and delete node add timeout for drain node
Which issue(s) this PR fixes:
feature#997
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: