Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1406] support recent k8s patch versions #1407

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

yjqg6666
Copy link
Contributor

@yjqg6666 yjqg6666 commented Jul 26, 2022

What type of PR is this?

/kind feature
Optionally add one or more of the following kinds if applicable:
/kind api-change

What this PR does / why we need it:

Use the recent patch releases.
Add the following k8s versions:

  • v1.22.11 + v1.22.12
  • v1.23.9
  • v1.24.2 + v1.24.3

Which issue(s) this PR fixes:

Fixes #1406

Special notes for reviewers:

The hashes are obtained use the following script. We could use bash+jq to generate the whole hash table and save to a temp file and vimdiff to add new version.

#!/bin/bash
vers=("v1.22.11" "v1.22.12" "v1.23.9" "v1.24.2" "v1.24.3")
arches=("amd64" "arm64")
apps=("kubeadm" "kubelet" "kubectl")
for app in "${apps[@]}";
do
    for arch in "${arches[@]}"
    do
        echo "${app}@${arch}"
        for ver in "${vers[@]}"
        do
            url="https://storage.googleapis.com/kubernetes-release/release/${ver}/bin/linux/${arch}/${app}.sha256"
            hash=$(wget --quiet -O - "$url")
            echo "\"${ver}\": \"${hash}\","
        done
    done
done

Does this PR introduced a user-facing change?

NO.

@ks-ci-bot ks-ci-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 26, 2022
@ks-ci-bot
Copy link
Collaborator

@yjqg6666: The label(s) kind/dependencies cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature
/kind dependencies

Optionally add one or more of the following kinds if applicable:
/kind api-change

What this PR does / why we need it:

Use the recent patch releases.

Which issue(s) this PR fixes:

Fixes #1406

Special notes for reviewers:

The hashes are obtained use the following script. We could use bash+jq to generate the whole hash table and save to a temp file and vimdiff to add new version.

#!/bin/bash
vers=("v1.22.11" "v1.22.12" "v1.23.9" "v1.24.2" "v1.24.3")
archs=("amd64" "arm64")
apps=("kubeadm" "kubelet" "kubectl")
for app in ${apps[@]};
do
   for arch in ${archs[@]}
   do
       echo "${app}@${arch}"
       for ver in ${vers[@]}
       do
           url="https://storage.googleapis.com/kubernetes-release/release/${ver}/bin/linux/${arch}/${app}.sha256"
           hash=$(wget --quiet -O - "$url")
           echo "\"${ver}\": \"${hash}\","
       done
   done
done

Does this PR introduced a user-facing change?

NO.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2022
@24sama
Copy link
Collaborator

24sama commented Jul 27, 2022

Hi @yjqg6666, thanks for your contributions! And this script is very useful!

@24sama
Copy link
Collaborator

24sama commented Jul 27, 2022

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 2fd3c655331f0d4ecec0f2478faab1480660f6f8

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama, yjqg6666

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@ks-ci-bot ks-ci-bot merged commit 38897fe into kubesphere:master Jul 27, 2022
@yjqg6666 yjqg6666 changed the title [#1406] support for recent k8s patch versions [#1406] support recent k8s patch versions Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support recent k8s patch versions
3 participants