Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete k3s cluster with kubenetes version #1426

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

xiaods
Copy link
Contributor

@xiaods xiaods commented Aug 7, 2022

fix issue: #1148

let below cmd works

./kk delete cluster --with-kubenetes v1.21.6-k3s

Signed-off-by: Deshi Xiao xiaods@gmail.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


fix issue: kubesphere#1148

let below cmd works
```
./kk delete cluster --with-kubenetes v1.21.6-k3s
```

Signed-off-by: Deshi Xiao <xiaods@gmail.com>
@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2022
@xiaods
Copy link
Contributor Author

xiaods commented Aug 7, 2022

/assign @rayzhou2017

@24sama
Copy link
Collaborator

24sama commented Aug 8, 2022

Thanks for your contributions! @xiaods

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 8d7bcb0f99468691dbc2ccbaf4a834dcad2ee7d4

@24sama
Copy link
Collaborator

24sama commented Aug 8, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama, xiaods

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@ks-ci-bot ks-ci-bot merged commit fe6c6da into kubesphere:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants