Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add versions of default plugins and components used by kubekey #1580

Merged

Conversation

xiaods
Copy link
Contributor

@xiaods xiaods commented Nov 7, 2022

fix issue #1433

Signed-off-by: Deshi Xiao xiaods@gmail.com

What type of PR is this?

/kind documentation

What this PR does / why we need it:

quote from request "like calico which default version information is in apis/kubekey/v1alpha1/default.go instead of a document , so have a document to show versions of plugins and components used by kubekey can help users troubleshoot version compatibility issues more easily"

this changed based on v1alpha2.

Which issue(s) this PR fixes:

Fixes #1433

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added kind/documentation Categorizes issue or PR as related to documentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 7, 2022
@24sama
Copy link
Collaborator

24sama commented Nov 8, 2022

Thanks @xiaods , but I guess you need to follow the v1alpha2 not v1alpha1.

fix issue#1433

Signed-off-by: Deshi Xiao <xiaods@gmail.com>
@xiaods xiaods force-pushed the fix-issue-1433-default-component-docs branch from 91bbad9 to c43463b Compare November 8, 2022 23:23
@xiaods
Copy link
Contributor Author

xiaods commented Nov 8, 2022

Thanks @xiaods , but I guess you need to follow the v1alpha2 not v1alpha1.

yes, it already based on v1alpha2. please give a review @24sama

@24sama
Copy link
Collaborator

24sama commented Nov 9, 2022

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 76744aa631f0fef754e77380ca16733cbf350153

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama, xiaods

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2022
@ks-ci-bot ks-ci-bot merged commit 0244404 into kubesphere:master Nov 9, 2022
@24sama
Copy link
Collaborator

24sama commented Nov 9, 2022

@all-contributors please add @xiaods for code, doc

@allcontributors
Copy link
Contributor

@24sama

I've put up a pull request to add @xiaods! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document to show versions of plugins and components
3 participants