fix remove node check #1666
Merged
fix remove node check #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ks-ci-bot
added
the
size/XS
|
/assign @rayzhou2017 |
|
/kind bug |
|
/assign pixiake |
|
@zhangzhiqiangcs Thanks for this contribution ！ |
|
@all-contributors please add @zhangzhiqiangcs for code |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 8c0551cdb444c5f3d740c7d43c1dffe939b95fd0
|
|
I've put up a pull request to add @zhangzhiqiangcs! 🎉 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pixiake, zhangzhiqiangcs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix remove node check may misstake hostnames that contains master string.
If node name is master-1, it will be considered a master node and forbidden remove the node.