Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify go mod path #1668

Merged
merged 1 commit into from
Dec 19, 2022
Merged

feat: modify go mod path #1668

merged 1 commit into from
Dec 19, 2022

Conversation

24sama
Copy link
Collaborator

@24sama 24sama commented Dec 19, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

feat: modify go mod path.
Because cluster-api clusterctl uses the goproxy to find the latest provider version, like using these link: https://proxy.golang.org/github.com/kubesphere/kubekey/v3/@v/list, but kk doesn't follow the go mod semver.

More info, please see:kubernetes-sigs/cluster-api#7700

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:

https://github.com/kubernetes-sigs/cluster-api/issues/7700

@ks-ci-bot ks-ci-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 19, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2022
Signed-off-by: 24sama <jacksama@foxmail.com>
@ks-ci-bot ks-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 19, 2022
@pixiake
Copy link
Collaborator

pixiake commented Dec 19, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 7f268ab8b86108b110764690cebf73261ff04b81

@ks-ci-bot ks-ci-bot merged commit db8aca4 into kubesphere:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants