Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: instruction on kubeVip module invocation #1695

Merged
merged 1 commit into from
Jan 12, 2023
Merged

docs: instruction on kubeVip module invocation #1695

merged 1 commit into from
Jan 12, 2023

Conversation

lwabish
Copy link
Contributor

@lwabish lwabish commented Jan 11, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

add some code comments to avoid confusion, see #1689

Which issue(s) this PR fixes:

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 11, 2023
@24sama
Copy link
Collaborator

24sama commented Jan 12, 2023

Thanks for your contribution!

@24sama
Copy link
Collaborator

24sama commented Jan 12, 2023

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 7ff90061666d890ec8386f1f9a7adb6692812912

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama, lwabish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@24sama
Copy link
Collaborator

24sama commented Jan 12, 2023

@all-contributors please add @lwabish for code, doc

@allcontributors
Copy link
Contributor

@24sama

I've put up a pull request to add @lwabish! 🎉

@ks-ci-bot ks-ci-bot merged commit da347af into kubesphere:master Jan 12, 2023
@lwabish
Copy link
Contributor Author

lwabish commented Jan 12, 2023

Cool, Thanks! By the way, I got another kube-vip related bug working in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants