Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename the file of action results for uniform naming #1732

Merged

Conversation

kiragoo
Copy link

@kiragoo kiragoo commented Feb 16, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

According to the other go files for results in package cmd/kk/pkg/core/ending, renam the file of action results for uniform naming.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Just rename the file of action result,without any user-facing changes.

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 16, 2023
@24sama
Copy link
Collaborator

24sama commented Feb 16, 2023

Thanks for the contribution @kiragoo

@kiragoo kiragoo force-pushed the chore-rename-file-for-action-results branch from 37d51b8 to 6a59ed5 Compare February 16, 2023 08:58
@ks-ci-bot ks-ci-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 16, 2023
@24sama
Copy link
Collaborator

24sama commented Feb 17, 2023

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 483d08f99261dec9390645be4e66b8129bd29ff5

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama, kiragoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2023
@ks-ci-bot ks-ci-bot merged commit 4ee8f2c into kubesphere:master Feb 17, 2023
@kiragoo kiragoo deleted the chore-rename-file-for-action-results branch February 20, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants