Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct the etcd related number type #1902

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented Jul 5, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

The example config file does not match with the latest code lines.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

None

See also

ElectionTimeout *int `yaml:"electionTimeout" json:"electionTimeout,omitempty"`

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

None

@ks-ci-bot ks-ci-bot added kind/documentation Categorizes issue or PR as related to documentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2023
@LinuxSuRen LinuxSuRen requested a review from pixiake July 5, 2023 02:32
@pixiake
Copy link
Collaborator

pixiake commented Jul 7, 2023

@LinuxSuRen Thanks for this contributions !
/lgrm
/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@pixiake
Copy link
Collaborator

pixiake commented Jul 7, 2023

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 95386aba70cf0ec07d96fdda24e3753062a20fb1

@ks-ci-bot ks-ci-bot merged commit 1cbd862 into kubesphere:master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants