fix: slice overflow panic sometimes during node info parsing #1955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug fixing
What this PR does / why we need it:
check slice ahead to avoid panic cause by slice index out of bounds.
when
sep
not empty,strings.Split
always return a slice which length larger than one, so the original check not working.if check not passed, return err for retry.
the pr is just a random thing for me after meeting a panic when using kk to setup my k8e cluster.
Which issue(s) this PR fixes:
It's easy to fix, so I didn't have a issue first about it.
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: