Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/support checksum of downloaded repository iso file #2254

Merged
merged 2 commits into from
May 29, 2024

Conversation

will4j
Copy link
Contributor

@will4j will4j commented May 26, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

When export artifact using repository iso url, each time the command kk artifact export was run, the iso file downloaded before will be overwrite and download again, which indeed is very annoying.

if checksum of local iso file matched, downloading can be skip, and the checksum is available at kubekey release site.

take examples below:

spec:
  arches:
    - amd64
  operatingSystems:
    - arch: amd64
      type: linux
      id: ubuntu
      version: "18.04"
      osImage: Ubuntu 18.04.6 LTS
      repository:
        iso:
          url: https://github.com/kubesphere/kubekey/releases/download/v3.1.1/ubuntu-18.04-debs-amd64.iso
          checksum: b69de0e6c6b789200d2de4febe9e9b214a4539c0d49da5ea826fff634d3b966d

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

Support checksum check to avoid repeat downloading from repository iso file url.

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 26, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@will4j
Copy link
Contributor Author

will4j commented May 26, 2024

/assign @pixiake

@will4j will4j changed the title Feature/os iso checksum feature/support checksum of downloaded repository iso file May 26, 2024
@pixiake
Copy link
Collaborator

pixiake commented May 29, 2024

@will4j Thanks for this contributions !
/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 1bcbe41478cc8fa650c5765fdb31aa2cb4979f81

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, will4j

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@ks-ci-bot ks-ci-bot merged commit 0ff0715 into kubesphere:master May 29, 2024
9 checks passed
@will4j will4j deleted the feature/os-iso-checksum branch June 2, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants