Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: --set contains multi string "=". #2351

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

redscholar
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

1, --set can set multi-value by separator , like this: --set k1=v1,k2=v2
2, compatible v1 string contains =

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Signed-off-by: joyceliu <joyceliu@yunify.com>
@ks-ci-bot ks-ci-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 8, 2024
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImitationImmortal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2024
@liangzai006
Copy link
Collaborator

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 70744d34c8f6f265880aaf51d9fdff507009ffdf

Signed-off-by: joyceliu <joyceliu@yunify.com>
@ks-ci-bot ks-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2024
Copy link

sonarcloud bot commented Aug 8, 2024

@pixiake
Copy link
Collaborator

pixiake commented Aug 9, 2024

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 99ede6bf6dc5fb90c6f904946d4a6586e0fa39e6

@ks-ci-bot ks-ci-bot merged commit 1aa519d into kubesphere:feature-gitops Aug 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants