Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo on command completion on completion.go #2413

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

Hiiirad
Copy link
Contributor

@Hiiirad Hiiirad commented Sep 24, 2024

Fixed a typo for command completion

What type of PR is this?

bug

What this PR does / why we need it:

Change the help output of the command completion. (the current help output had a typo)

Which issue(s) this PR fixes:

No reported issues will be fixed!

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Fixed a typo on command completion on completion.go

Additional documentation, usage docs, etc.:


Fixed a typo for command completion
Copy link

Welcome @Hiiirad! It looks like this is your first PR to kubesphere/kubekey 🎉

@kubesphere-prow kubesphere-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 24, 2024
@pixiake
Copy link
Collaborator

pixiake commented Sep 26, 2024

@Hiiirad Thanks for this contributions !
/lgtm
/approve

@kubesphere-prow kubesphere-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
Copy link

LGTM label has been added.

Git tree hash: fa9eb07db220c95bf4e287a7b16bf0787ec5a293

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Hiiirad, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note and removed do-not-merge/release-note-label-needed labels Sep 26, 2024
@pixiake
Copy link
Collaborator

pixiake commented Sep 26, 2024

@all-contributors please add @Hiiirad for code

Copy link
Contributor

@pixiake

I've put up a pull request to add @Hiiirad! 🎉

@kubesphere-prow kubesphere-prow bot merged commit e6a6ec0 into kubesphere:master Sep 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants