Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable namespaceOverride on images push #2438

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

pixiake
Copy link
Collaborator

@pixiake pixiake commented Oct 30, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

disable namespaceOverride on images push

kubekey already supports pushing multi-level path images. such as docker.io/kubesphere/kube-apiserver:v1.31.2 to dockerhub.kubekey.local/ks/kubesphere/kube-apiserver:v1.31.2. So we can push images to the same project by this way.

configuration example:

...
registry:
   privateRegistry: "dockerhub.kubekey.local/ks"   # If the repository is harbor, this configuration will push all images to the ks project

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

disable namespaceOverride on images push

Additional documentation, usage docs, etc.:


Signed-off-by: pixiake <guofeng@yunify.com>
@kubesphere-prow kubesphere-prow bot added release-note kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 30, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 30, 2024
Copy link

sonarcloud bot commented Oct 30, 2024

@liangzai006
Copy link
Collaborator

/lgtm

@kubesphere-prow kubesphere-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
Copy link

LGTM label has been added.

Git tree hash: d9c9e2d022cf25bd8e93f9fc8bad2fa9032111d4

@ks-ci-bot ks-ci-bot merged commit 0067d39 into kubesphere:master Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants