-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Addon #603] Add Apache Spark as a experimental addon #629
Conversation
Hi @yanghua , is this pr still in progress. |
Yes, considering Spark is a big engine and the Spark on Kubernetes operator provides a very comprehensive ability. I am still improving it and verifying it in our local env. Thanks for your patience. |
Hi @wangyikewxgm I will provide a basic version of this addon. More advanced features would be iterated in the future. WDYT? |
OK,thanks for your contribution. |
Signed-off-by: yanghua <yanghua1127@gmail.com>
b492faa
to
843319f
Compare
Signed-off-by: yanghua <yanghua1127@gmail.com>
Signed-off-by: yanghua <yanghua1127@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your contribution. Based on the successful enabling of this add-on and its clear and explicit introduction, I believe this PR is ready to be merged. In the future, we can make some optimizations for this addon, such as adding a topology rule configuration.
Good suggestion, will iterate more advanced feature soon. |
experimental/addons/spark-kubernetes-operator/definitions/spark-application.cue
Outdated
Show resolved
Hide resolved
experimental/addons/spark-kubernetes-operator/definitions/spark-application.cue
Outdated
Show resolved
Hide resolved
Signed-off-by: yanghua <yanghua1127@gmail.com>
Signed-off-by: yanghua <yanghua1127@gmail.com>
Signed-off-by: yanghua <yanghua1127@gmail.com>
Signed-off-by: yanghua <yanghua1127@gmail.com>
63165fe
to
1c0cf18
Compare
Signed-off-by: yanghua <yanghua1127@gmail.com>
043d7df
to
8916021
Compare
… and add spark-py example Signed-off-by: yanghua <yanghua1127@gmail.com>
4b52ee4
to
7036a63
Compare
… (add proxyUser option) Signed-off-by: yanghua <yanghua1127@gmail.com>
@wonderflow Any input about this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally LGTM, ping @wangyikewxgm it would be better if we don't rely on kubectl
in the readme of addons.
Signed-off-by: yanghua yanghua1127@gmail.com
Description of your changes
How has this code been tested?
Checklist
I have:
[Addon]
,[example]
or[Doc]
).version
inmetadata.yaml
to generate a new version.Verified Addon promotion rules
If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:
metadata.yaml
.README.md
.