Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon]: VelaUX ingress expose class name parameter #740

Closed
wants to merge 3 commits into from
Closed

[Addon]: VelaUX ingress expose class name parameter #740

wants to merge 3 commits into from

Conversation

oanasc
Copy link
Contributor

@oanasc oanasc commented Nov 24, 2023

Description of your changes

Fixes ##739

How has this code been tested?

Tested by enabling the addon on a cluster with multiple nginx's and confirmed the ingress was correctly created and UX running
vela addon enable velaux/ domain=<mydomain> gatewayDriver=nginx class=<myclassname>

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules

If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

  • This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
  • This addon must have some basic but necessary information.
    • An accessible icon url and source url defined in addon's metadata.yaml.
    • A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
    • Also provide an introduction in KubeVela documentation.
    • It's more likely to be accepted if useful examples provided in example dir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant